This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Get rid of the suppressChangedStoreWarning flag leftovers#742
Merged
danielkcz merged 2 commits intoAug 1, 2019
Merged
Conversation
Contributor
|
Looking at those links it's clear it's related to the legacy context and as such it's misleading. I am really convinced we shouldn't prevent this if someone really wants that. There is no actual harm in that. It's not about recreating stores, just the context object itself and the only downside is it will re-render a whole tree from that Provider. |
Contributor
Author
|
I would like to wait for @mweststrate comment about this restriction. I'd like to suggest the following:
|
Contributor
Author
|
I want to merge it anyway, because in theory we'll have to wait a long time for comment. |
danielkcz
reviewed
Aug 1, 2019
Co-Authored-By: Daniel K. <FredyC@users.noreply.github.com>
vkrol
deleted the
get-rid-of-suppress-changed-store-warning-flag-leftovers
branch
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag was deleted in 6.0.0 but there are some leftovers. The quote from the 6.0.0 changelog:
and